8000 Some more refactoring. · jsullivanlive/github3.py@2518894 · GitHub
[go: up one dir, main page]

Skip to content

Commit 2518894

Browse files
committed
Some more refactoring.
1 parent 258ad73 commit 2518894

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

github3/org.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ def delete(self):
104104
"""
105105
return self._boolean(self._delete(self._api), 204, 404)
106106

107-
#XXX
108107
@GitHubCore.requires_auth
109108
def edit(self, name, permission=''):
110109
"""Edit this team.
@@ -117,7 +116,7 @@ def edit(self, name, permission=''):
117116
"""
118117
if name:
119118
data = dumps({'name': name, 'permission': permission})
120-
json = self._patch(self._api, data)
119+
json = self._json(self._patch(self._api, data), 200)
121120
if json:
122121
self._update_(json)
123122
return True
@@ -130,8 +129,8 @@ def has_repo(self, repo):
130129
:type repo: str
131130
:returns: bool
132131
"""
133-
url = '{0}/repos/{1}'.format(self._api, repo)
134-
return self._session.get(url).status_code == 204
132+
url = self._build_url('repos', repo, base_url=self._api)
133+
return self._boolean(self._get(url), 204, 404)
135134

136135
@property
137136
def id(self):
@@ -145,18 +144,17 @@ def is_member(self, login):
145144
:type login: str
146145
:returns: bool
147146
"""
148-
url = '{0}/members/{1}'.format(self._api, login)
149-
return self._session.get(url).status_code == 204
147+
url = self._build_url('members', login, base_url=self._api)
148+
return self._boolean(self._get(url), 204, 404)
150149

151150
def list_members(self):
152151
"""List the members of this team.
153152
154153
:returns: list of :class:`User <github3.user.User>`\ s
155154
"""
156-
url = self._api + '/members'
157-
json = self._get(url)
158-
ses = self._session
159-
return [User(m, ses) for m in json]
155+
url = self._build_url('members', base_url=self._api)
156+
json = self._json(self._get(url), 200)
157+
return [User(m, self) for m in json]
160158

161159
def list_repos(self):
162160
"""List the repositories this team has access to.

0 commit comments

Comments
 (0)
0