8000 Add ability to rename workbook using the 'update workbook' endpoint (… · jsonhuff/server-client-python@df44535 · GitHub
[go: up one dir, main page]

Skip to content

Commit df44535

Browse files
authored
Add ability to rename workbook using the 'update workbook' endpoint (tableau#284)
* adding ability to rename workbook using workbooks.update() * updating test
1 parent ad1be7d commit df44535

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

tableauserverclient/server/request_factory.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,8 @@ def _generate_xml(self, workbook_item, connection_credentials=None):
334334
def update_req(self, workbook_item):
335335
xml_request = ET.Element('tsRequest')
336336
workbook_element = ET.SubElement(xml_request, 'workbook')
337+
if workbook_item.name:
338+
workbook_element.attrib['name'] = workbook_item.name
337339
if workbook_item.show_tabs:
338340
workbook_element.attrib['showTabs'] = str(workbook_item.show_tabs).lower()
339341
if workbook_item.project_id:

test/assets/workbook_update.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version='1.0' encoding='UTF-8'?>
22
<tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.3.xsd">
3-
<workbook id="1f951daf-4061-451a-9df1-69a8062664f2" name="RESTAPISample" contentUrl="RESTAPISample" showTabs="true" size="1" createdAt="2016-08-18T18:25:36Z" updatedAt="2016-08-18T18:29:36Z">
3+
<workbook id="1f951daf-4061-451a-9df1-69a8062664f2" name="renamedWorkbook" contentUrl="RESTAPISample" showTabs="true" size="1" createdAt="2016-08-18T18:25:36Z" updatedAt="2016-08-18T18:29:36Z">
44
<project id="1d0304cd-3796-429f-b815-7258370b9b74" name="Tableau" />
55
<owner id="dd2239f6-ddf1-4107-981a-4cf94e415794" />
66
<tags />

test/test_workbook.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,14 @@ def test_update(self):
114114
single_workbook = TSC.WorkbookItem('1d0304cd-3796-429f-b815-7258370b9b74', show_tabs=True)
115115
single_workbook._id = '1f951daf-4061-451a-9df1-69a8062664f2'
116116
single_workbook.owner_id = 'dd2239f6-ddf1-4107-981a-4cf94e415794'
117+
single_workbook.name = 'renamedWorkbook'
117118
single_workbook = self.server.workbooks.update(single_workbook)
118119

119120
self.assertEqual('1f951daf-4061-451a-9df1-69a8062664f2', single_workbook.id)
120121
self.assertEqual(True, single_workbook.show_tabs)
121122
self.assertEqual('1d0304cd-3796-429f-b815-7258370b9b74', single_workbook.project_id)
122123
self.assertEqual('dd2239f6-ddf1-4107-981a-4cf94e415794', single_workbook.owner_id)
124+
self.assertEqual('renamedWorkbook', single_workbook.name)
123125

124126
def test_update_missing_id(self):
125127
single_workbook = TSC.WorkbookItem('test')

0 commit comments

Comments
 (0)
0