array.$remove: always remove by searching for item

yyx990803 · yyx990803 · commit c427029b6478 · 2015-09-30T23:31:47.000-04:00
diff --git a/src/observer/array.js b/src/observer/array.js
@@ -83,12 +83,10 @@ _.define(
 _.define(
   arrayProto,
   '$remove',
-  function $remove (index) {
+  function $remove (item) {
     /* istanbul ignore if */
     if (!this.length) return
-    if (typeof index !== 'number') {
-      index = _.indexOf(this, index)
-    }
+    var index = _.indexOf(this, item)
     if (index > -1) {
       return this.splice(index, 1)
     }
diff --git a/test/unit/specs/observer/observer_spec.js b/test/unit/specs/observer/observer_spec.js
@@ -153,11 +153,6 @@ describe('Observer', function () {
     var ob = Observer.create(arr)
     var dep = ob.dep
     spyOn(dep, 'notify')
-    // remove by index
-    arr.$remove(0)
-    expect(arr.length).toBe(1)
-    expect(arr[0]).toBe(obj2)
-    expect(dep.notify.calls.count()).toBe(1)
     // remove by identity, not in array
     arr.$remove(obj1)
     expect(arr.length).toBe(1)
