Use subspawn by default for process launching #8221
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subspawn library is a better and cleaner implementation of Ruby's spawn (and friends) and we should try to move toward using it by default. A few things are needed for this:
spawn
andpopen
(and anything else, like backquotes) to be the ones built on subspawn.posix_spawn
, similar to the old logic but using subspawn's much cleaner argument processing etc.