Fix host|file condition in session backend.

nicolasff · nicolasff · commit f3dff08cfaf5 · 2012-07-09T21:47:54.000+01:00
Should address phpredis#184. Adding a slash at the end would make phpredis consider "/" as the path and ignore the host. Having a host name now takes precedence over having a file name.
diff --git a/redis_session.c b/redis_session.c
@@ -251,10 +251,10 @@ PS_OPEN_FUNC(redis)
 			}
 
 			RedisSock *redis_sock;
-            if(url->path) { /* unix */
-                    redis_sock = redis_sock_create(url->path, strlen(url->path), 0, timeout, persistent, persistent_id);
-            } else {
+            if(url->host) {
                     redis_sock = redis_sock_create(url->host, strlen(url->host), url->port, timeout, persistent, persistent_id);
+            } else { /* unix */
+                    redis_sock = redis_sock_create(url->path, strlen(url->path), 0, timeout, persistent, persistent_id);
             }
 			redis_pool_add(pool, redis_sock, weight, prefix, auth TSRMLS_CC);
 

Original file line number	Diff line number	Diff line change
`@@ -251,10 +251,10 @@ PS_OPEN_FUNC(redis)`
`251`	`251`	`}`
`252`	`252`
`253`	`253`	`RedisSock *redis_sock;`
`254`		`- if(url->path) { /* unix */`
`255`		`- redis_sock = redis_sock_create(url->path, strlen(url->path), 0, timeout, persistent, persistent_id);`
`256`		`- } else {`
	`254`	`+ if(url->host) {`
`257`	`255`	`redis_sock = redis_sock_create(url->host, strlen(url->host), url->port, timeout, persistent, persistent_id);`
	`256`	`+ } else { /* unix */`
	`257`	`+ redis_sock = redis_sock_create(url->path, strlen(url->path), 0, timeout, persistent, persistent_id);`
`258`	`258`	`}`
`259`	`259`	`redis_pool_add(pool, redis_sock, weight, prefix, auth TSRMLS_CC);`
`260`	`260`