Fixes bug when checking for failure in php_stream_gets

michael-grunder · michael-grunder · commit c32e2fe3e0ca · 2015-12-17T21:41:50.000-08:00
Addresses phpredis#672
diff --git a/library.c b/library.c
@@ -2161,7 +2161,7 @@ redis_read_reply_type(RedisSock *redis_sock, REDIS_REPLY_TYPE *reply_type,
         char inbuf[255];
 
 		/* Read up to our newline */
-		if(php_stream_gets(redis_sock->stream, inbuf, sizeof(inbuf)) < 0) {
+		if(php_stream_gets(redis_sock->stream, inbuf, sizeof(inbuf)) == NULL) {
 			return -1;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -2161,7 +2161,7 @@ redis_read_reply_type(RedisSock redis_sock, REDIS_REPLY_TYPE reply_type,`
`2161`	`2161`	`char inbuf[255];`
`2162`	`2162`
`2163`	`2163`	`/* Read up to our newline */`
`2164`		`- if(php_stream_gets(redis_sock->stream, inbuf, sizeof(inbuf)) < 0) {`
	`2164`	`+ if(php_stream_gets(redis_sock->stream, inbuf, sizeof(inbuf)) == NULL) {`
`2165`	`2165`	`return -1;`
`2166`	`2166`	`}`
`2167`	`2167`