Fix leak in get response

michael-grunder · michael-grunder · commit bfbdaa9c0a77 · 2015-12-21T11:08:28.000-08:00
PHP 7 has done away with the third argument to RETURN_STRINGL
(where one could decide if the string was to be duplicated or not)
meaning that we now need to free our response as RETVAL_STRINGL
will duplicate the string.

I'm not sure what the proper solution is for this in php7
diff --git a/library.c b/library.c
@@ -1407,7 +1407,8 @@ PHP_REDIS_API void redis_string_response(INTERNAL_FUNCTION_PARAMETERS, RedisSock
         if(redis_unserialize(redis_sock, response, response_len,
                              return_value TSRMLS_CC) == 0)
         {
-            RETURN_STRINGL(response, response_len);
+            RETVAL_STRINGL(response, response_len);
+            efree(response);
         } else {
             efree(response);
         }

Original file line number	Diff line number	Diff line change
`@@ -1407,7 +1407,8 @@ PHP_REDIS_API void redis_string_response(INTERNAL_FUNCTION_PARAMETERS, RedisSock`
`1407`	`1407`	`if(redis_unserialize(redis_sock, response, response_len,`
`1408`	`1408`	`return_value TSRMLS_CC) == 0)`
`1409`	`1409`	`{`
`1410`		`- RETURN_STRINGL(response, response_len);`
	`1410`	`+ RETVAL_STRINGL(response, response_len);`
	`1411`	`+ efree(response);`
`1411`	`1412`	`} else {`
`1412`	`1413`	`efree(response);`
`1413`	`1414`	`}`