Complete exercise 12

josh-Fen · josh-Fen · commit 21de113d6e94 · 2024-05-11T20:13:07.000-04:00
diff --git a/12_findTheOldest/findTheOldest.js b/12_findTheOldest/findTheOldest.js
@@ -1,5 +1,20 @@
-const findTheOldest = function() {
+const findTheOldest = function (arr) {
+    return arr.reduce((obj, element) => {
 
+        if (!obj.yearOfBirth) {
+            return element;
+        }
+
+        const birth = element.yearOfBirth;
+        const death = element.yearOfDeath ? element.yearOfDeath : new Date().getFullYear();
+        const yearsAlive = death - birth;
+
+        const objBirth = obj.yearOfBirth;
+        const objDeath = obj.yearOfDeath ? obj.yearOfDeath : new Date().getFullYear();
+        const objYearsAlive = objDeath - objBirth;
+
+        return yearsAlive > objYearsAlive ? element : obj;
+    }, {});
 };
 
 // Do not edit below this line
diff --git a/12_findTheOldest/findTheOldest.spec.js b/12_findTheOldest/findTheOldest.spec.js
@@ -21,7 +21,7 @@ describe('findTheOldest', () => {
     ]
     expect(findTheOldest(people).name).toBe('Ray');
   });
-  test.skip('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {
+  test('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {
     const people = [
       {
         name: "Carly",
@@ -40,7 +40,7 @@ describe('findTheOldest', () => {
     ]
     expect(findTheOldest(people).name).toBe('Ray');
   });
-  test.skip('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {
+  test('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {
     const people = [
       {
         name: "Carly",

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ describe('findTheOldest', () => {`
`21`	`21`	`]`
`22`	`22`	`expect(findTheOldest(people).name).toBe('Ray');`
`23`	`23`	`});`
`24`		`- test.skip('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {`
	`24`	`+ test('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {`
`25`	`25`	`const people = [`
`26`	`26`	`{`
`27`	`27`	`name: "Carly",`
`@@ -40,7 +40,7 @@ describe('findTheOldest', () => {`
`40`	`40`	`]`
`41`	`41`	`expect(findTheOldest(people).name).toBe('Ray');`
`42`	`42`	`});`
`43`		`- test.skip('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {`
	`43`	`+ test('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {`
`44`	`44`	`const people = [`
`45`	`45`	`{`
`46`	`46`	`name: "Carly",`