Add RuntimeError for queryset positional arguments

jorwoods · Jordan Woods · commit 8242815f7eec · 2022-01-28T08:40:24.000-06:00
diff --git a/tableauserverclient/server/endpoint/endpoint.py b/tableauserverclient/server/endpoint/endpoint.py
@@ -230,7 +230,9 @@ def all(self, *args, **kwargs):
         return queryset
 
     @api(version="2.0")
-    def filter(self, *args, **kwargs):
+    def filter(self, *_, **kwargs):
+        if _:
+            raise RuntimeError("Only keyword arguments accepted.")
         queryset = QuerySet(self).filter(**kwargs)
         return queryset
 
diff --git a/tableauserverclient/server/query.py b/tableauserverclient/server/query.py
@@ -92,7 +92,7 @@ def page_size(self):
 
     def filter(self, *invalid, **kwargs):
         if invalid:
-            raise ValueError(f"Only accepts keyword arguments.")
+            raise RuntimeError(f"Only accepts keyword arguments.")
         for kwarg_key, value in kwargs.items():
             field_name, operator = self._parse_shorthand_filter(kwarg_key)
             self.request_options.filter.add(Filter(field_name, operator, value))
diff --git a/test/test_request_option.py b/test/test_request_option.py
@@ -270,4 +270,8 @@ def test_slicing_queryset(self):
             self.assertEqual(all_views[-3].id, "2df55de2-3a2d-4e34-b515-6d4e70b830e9")
         
         with self.assertRaises(IndexError):
-            all_views[100]
+            all_views[100]
+
+    def test_queryset_filter_args_error(self):
+        with self.assertRaises(RuntimeError):
+            workbooks = self.server.workbooks.filter("argument")
