8000 quotes · jorgewqs/firebase-admin-python@7bde4f2 · GitHub
[go: up one dir, main page]

Skip to content 8000

Commit 7bde4f2

Browse files
committed
quotes
1 parent e7b8636 commit 7bde4f2

File tree

4 files changed

+12
-13
lines changed

4 files changed

+12
-13
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
for all egress requests. Pass the `httpTimeout` option
1313
to `firebase_admin.initialize_app()` before invoking any functions in
1414
`messaging`.
15-
1615
- [added] The Firebase dynamic links module with the `get_link_stats` API.
1716

1817
# v2.9.0

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,11 @@ Now you can invoke the integration test suite as follows:
177177
pytest integration/ --cert path/to/service_acct.json --apikey path/to/apikey.txt
178178
```
179179

180-
### End to end testing for dynamic links.
180+
### End-to-End Testing for Dynamic Links.
181181

182-
To run end to end tests for Firebase dynamic links follow these steps:
182+
To run end-to-end tests for Firebase dynamic links follow these steps:
183183

184-
1. From the firebase console, create a short link under "Grow > Dynamic Links".
184+
1. From the [`Firebase Console`](https://firebase.corp.google.com/), create a short link in your project under "`Grow` > `Dynamic Links`".
185185
2. From your browser or phone, go to that short link and see that it redirects as desired.
186186
3. Wait up to 36 hours for stats to show up on the console.
187187
4. Create a file at `tests/data/dynamic_links_e2e_url.txt` containing the short link,

firebase_admin/dynamic_links.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,18 +39,18 @@
3939
EVENT_TYPE_APP_RE_OPEN = 'app_re_open'
4040

4141
def get_link_stats(short_link, stat_options, app=None):
42-
""" Returns a `LinkStats` object with the event statistics for the given short link
42+
""" Returns a ``LinkStats`` object with the event statistics for the given short link
4343
4444
Args:
4545
short_link: The string of the designated short link. e.g. https://abc12.app.goo.gl/link
4646
The link must belong to the project associated with the service account
4747
used to call this API.
4848
stat_options: An object containing a single field "duration_days" for which the statistics
4949
are retrieved.
50-
app: (optional) `firebase_app` instance. (If missing uses default app.)
50+
app: A Firebase ``App instance`` (optional). (If missing uses default app.)
5151
5252
Returns:
53-
LinkStats: An `LinkStats` object. (containing an array of `EventStats`)
53+
LinkStats: An ``LinkStats`` object. (containing an array of ``EventStats``)
5454
5555
Raises:
5656
ValueError: If any of the arguments are invalid.
@@ -79,7 +79,7 @@ def _get_link_service(app):
7979

8080

8181
class LinkStats(object):
82-
"""The `LinkStats` object is returned by get_link_stats, it contains a list of `EventStats`"""
82+
"""The ``LinkStats`` object is returned by get_link_stats, it contains a list of ``EventStats``"""
8383
def __init__(self, event_stats):
8484
if not isinstance(event_stats, (list, tuple)):
8585
raise ValueError('Invalid data argument: {0}. Must be a list or tuple'
@@ -94,12 +94,12 @@ def event_stats(self):
9494
"""Returns the event statistics for this link, for the requested period.
9595
9696
Returns:
97-
event_stats: A list of `EventStats`.
97+
event_stats: A list of ``EventStats``.
9898
"""
9999
return self._stats
100100

101101
class EventStats(object):
102-
"""`EventStats` is a single stat item containing (platform, event, count)"""
102+
"""``EventStat`` is a single stat item containing (platform, event, count)"""
103103

104104
_platforms = {
105105
'DESKTOP': PLATFORM_DESKTOP,

integration/test_dynamic_links.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525
try:
2626
dynamic_links_e2e_url = testutils.resource('dynamic_links_e2e_url.txt').strip()
2727
except IOError:
28-
sys.stderr.write("\nEnd to end tests not set up, see CONTRIBUTING.md file.\n")
28+
sys.stderr.write("\nEnd-to-end tests not set up, see CONTRIBUTING.md file.\n")
2929

3030
@pytest.mark.skipif(not dynamic_links_e2e_url,
31-
reason="End to end tests not set up, see CONTRIBTING.md file.")
31+
reason="End-to-end tests not set up, see CONTRIBTING.md file.")
3232
class TestEndToEnd(object):
33-
"""Runs an end to end test, see comment string for setup."""
33+
"""Runs an end-to-end test, see comment string for setup."""
3434

3535
def test_get_stats(self):
3636
if not dynamic_links_e2e_url:

0 commit comments

Comments
 (0)
0