fix(bump): fix error due to bumping version file without eol through regex

Lee-W · Lee-W · commit 76b3030f65ac · 2021-05-26T22:11:53.000+08:00
diff --git a/commitizen/bump.py b/commitizen/bump.py
@@ -186,9 +186,11 @@ def _bump_with_regex(version_file_contents, current_version, new_version, regex)
     for match in re.finditer(regex, version_file_contents, re.MULTILINE):
         left = version_file_contents[: match.end() + offset]
         right = version_file_contents[match.end() + offset :]
-        line_break = _get_line_break_position(right)
+
+        line_break = right.find("\n")
         middle = right[:line_break]
         right = right[line_break:]
+
         if current_version in middle:
             offset += len(new_version) - len(current_version)
             current_version_found = True
@@ -198,11 +200,6 @@ def _bump_with_regex(version_file_contents, current_version, new_version, regex)
     return current_version_found, version_file_contents
 
 
-def _get_line_break_position(text: str) -> int:
-    position = text.find("\n")
-    return max(position, 0)
-
-
 def _version_to_regex(version: str):
     clean_regex = version.replace(".", r"\.").replace("+", r"\+")
     return re.compile(f"{clean_regex}")
