joncham
diff --git a/‎LibGit2Sharp.Tests/BranchFixture.cs
Lines changed: 41 additions & 3 deletions b/‎LibGit2Sharp.Tests/BranchFixture.cs
Lines changed: 41 additions & 3 deletions
diff --git a/‎LibGit2Sharp/BranchCollection.cs
Lines changed: 2 additions & 1 deletion b/‎LibGit2Sharp/BranchCollection.cs
Lines changed: 2 additions & 1 deletion
@@ -161,7 +161,26 @@ public void CreatingBranchWithEmptyNameThrows()
         {
             using (var repo = new Repository(Constants.TestRepoPath))
             {
-                Assert.Throws<ArgumentException>(() => repo.Branches.Create(string.Empty, "not_important_sha"));
+                Assert.Throws<ArgumentException>(() => repo.Branches.Create(string.Empty, repo.Head.ResolveToDirectReference().TargetIdentifier));
+            }
+        }
+
+        [Test]
+        [Ignore("Not implemented yet.")]
+        public void CreatingBranchWithUnknownNamedTargetThrows()
+        {
+            using (var repo = new Repository(Constants.TestRepoPath))
+            {
+                Assert.Throws<ArgumentException>(() => repo.Branches.Create("my_new_branch", "my_old_branch"));
+            }
+        }
+
+        [Test]
+        public void CreatingBranchWithUnknownShaTargetThrows()
+        {
+            using (var repo = new Repository(Constants.TestRepoPath))
+            {
+                Assert.Throws<ApplicationException>(() => repo.Branches.Create("my_new_branch", Constants.UnknownSha));
             }
         }
 
@@ -179,7 +198,7 @@ public void CreatingBranchWithNullNameThrows()
         {
             using (var repo = new Repository(Constants.TestRepoPath))
             {
-                Assert.Throws<ArgumentNullException>(() => repo.Branches.Create(null, "not_important_sha"));
+                Assert.Throws<ArgumentNullException>(() => repo.Branches.Create(null, repo.Head.ResolveToDirectReference().TargetIdentifier));
             }
         }
 
@@ -260,6 +279,7 @@ public void CanMoveABranch()
                 repo.Branches["br3"].ShouldNotBeNull();
             }
         }
+
         [Test]
         public void BlindlyMovingABranchOverAnExistingOneThrows()
         {
@@ -294,5 +314,23 @@ public void CanMoveABranchWhileOverwritingAnExistingOne()
                 newTest.Tip.ShouldEqual(br2.Tip);
             }
         }
+        
+        [Test]
+        public void CreatingABranchTriggersTheCreationOfADirectReference()
+        {
+            using (var path = new TemporaryCloneOfTestRepo())
+            using (var repo = new Repository(path.RepositoryPath))
+            {
+                var newBranch = repo.CreateBranch("clone-of-master");
+                newBranch.IsCurrentRepositoryHead.ShouldBeFalse();
+                
+                var commitId = repo.Head.ResolveToDirectReference().TargetIdentifier;
+                newBranch.Tip.Sha.ShouldEqual(commitId);
+
+                var reference = repo.Refs[newBranch.CanonicalName];
+                reference.ShouldNotBeNull();
+                Assert.IsInstanceOf(typeof (DirectReference), reference);
+            }
+        }
     }
-}
+}
@@ -83,7 +83,8 @@ public Branch Create(string name, string target)
 
             if (id == null)
             {
-                target = NormalizeToCanonicalName(target);
+                var reference = repo.Refs[NormalizeToCanonicalName(target)].ResolveToDirectReference();
+                target = reference.TargetIdentifier;
             }
 
             repo.Refs.Create(NormalizeToCanonicalName(name), target);
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,26 @@ public void CreatingBranchWithEmptyNameThrows()`
`161`	`161`	`{`
`162`	`162`	`using (var repo = new Repository(Constants.TestRepoPath))`
`163`	`163`	`{`
`164`		`- Assert.Throws<ArgumentException>(() => repo.Branches.Create(string.Empty, "not_important_sha"));`
	`164`	`+ Assert.Throws<ArgumentException>(() => repo.Branches.Create(string.Empty, repo.Head.ResolveToDirectReference().TargetIdentifier));`
	`165`	`+ }`
	`166`	`+ }`
	`167`	`+`
	`168`	`+ [Test]`
	`169`	`+ [Ignore("Not implemented yet.")]`
	`170`	`+ public void CreatingBranchWithUnknownNamedTargetThrows()`
	`171`	`+ {`
	`172`	`+ using (var repo = new Repository(Constants.TestRepoPath))`
	`173`	`+ {`
	`174`	`+ Assert.Throws<ArgumentException>(() => repo.Branches.Create("my_new_branch", "my_old_branch"));`
	`175`	`+ }`
	`176`	`+ }`
	`177`	`+`
	`178`	`+ [Test]`
	`179`	`+ public void CreatingBranchWithUnknownShaTargetThrows()`
	`180`	`+ {`
	`181`	`+ using (var repo = new Repository(Constants.TestRepoPath))`
	`182`	`+ {`
	`183`	`+ Assert.Throws<ApplicationException>(() => repo.Branches.Create("my_new_branch", Constants.UnknownSha));`
`165`	`184`	`}`
`166`	`185`	`}`
`167`	`186`
`@@ -179,7 +198,7 @@ public void CreatingBranchWithNullNameThrows()`
`179`	`198`	`{`
`180`	`199`	`using (var repo = new Repository(Constants.TestRepoPath))`
`181`	`200`	`{`
`182`		`- Assert.Throws<ArgumentNullException>(() => repo.Branches.Create(null, "not_important_sha"));`
	`201`	`+ Assert.Throws<ArgumentNullException>(() => repo.Branches.Create(null, repo.Head.ResolveToDirectReference().TargetIdentifier));`
`183`	`202`	`}`
`184`	`203`	`}`
`185`	`204`
`@@ -260,6 +279,7 @@ public void CanMoveABranch()`
`260`	`279`	`repo.Branches["br3"].ShouldNotBeNull();`
`261`	`280`	`}`
`262`	`281`	`}`
	`282`	`+`
`263`	`283`	`[Test]`
`264`	`284`	`public void BlindlyMovingABranchOverAnExistingOneThrows()`
`265`	`285`	`{`
`@@ -294,5 +314,23 @@ public void CanMoveABranchWhileOverwritingAnExistingOne()`
`294`	`314`	`newTest.Tip.ShouldEqual(br2.Tip);`
`295`	`315`	`}`
`296`	`316`	`}`
	`317`	`+`
	`318`	`+ [Test]`
	`319`	`+ public void CreatingABranchTriggersTheCreationOfADirectReference()`
	`320`	`+ {`
	`321`	`+ using (var path = new TemporaryCloneOfTestRepo())`
	`322`	`+ using (var repo = new Repository(path.RepositoryPath))`
	`323`	`+ {`
	`324`	`+ var newBranch = repo.CreateBranch("clone-of-master");`
	`325`	`+ newBranch.IsCurrentRepositoryHead.ShouldBeFalse();`
	`326`	`+`
	`327`	`+ var commitId = repo.Head.ResolveToDirectReference().TargetIdentifier;`
	`328`	`+ newBranch.Tip.Sha.ShouldEqual(commitId);`
	`329`	`+`
	`330`	`+ var reference = repo.Refs[newBranch.CanonicalName];`
	`331`	`+ reference.ShouldNotBeNull();`
	`332`	`+ Assert.IsInstanceOf(typeof (DirectReference), reference);`
	`333`	`+ }`
	`334`	`+ }`
`297`	`335`	`}`
`298`		`-}`
	`336`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,8 @@ public Branch Create(string name, string target)`
`83`	`83`
`84`	`84`	`if (id == null)`
`85`	`85`	`{`
`86`		`- target = NormalizeToCanonicalName(target);`
	`86`	`+ var reference = repo.Refs[NormalizeToCanonicalName(target)].ResolveToDirectReference();`
	`87`	`+ target = reference.TargetIdentifier;`
`87`	`88`	`}`
`88`	`89`
`89`	`90`	`repo.Refs.Create(NormalizeToCanonicalName(name), target);`