extmod/nimble: Don't assert on save-IRK failure.

jimmo · dpgeorge · commit f7aafc0628f2 · 2020-12-23T10:08:00.000+11:00
diff --git a/extmod/nimble/modbluetooth_nimble.c b/extmod/nimble/modbluetooth_nimble.c
@@ -227,7 +227,9 @@ STATIC int load_irk(void) {
         }
         DEBUG_printf("load_irk: Saving new IRK.\n");
         if (!mp_bluetooth_gap_on_set_secret(SECRET_TYPE_OUR_IRK, key, sizeof(key), rand_irk, 16)) {
-            return BLE_HS_EINVAL;
+            // Code that doesn't implement pairing/bonding won't support set/get secret.
+            // So they'll just get the default fixed IRK.
+            return 0;
         }
         DEBUG_printf("load_irk: Applying new IRK.\n");
         rc = ble_hs_pvcy_set_our_irk(rand_irk);

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,9 @@ STATIC int load_irk(void) {`
`227`	`227`	`}`
`228`	`228`	`DEBUG_printf("load_irk: Saving new IRK.\n");`
`229`	`229`	`if (!mp_bluetooth_gap_on_set_secret(SECRET_TYPE_OUR_IRK, key, sizeof(key), rand_irk, 16)) {`
`230`		`- return BLE_HS_EINVAL;`
	`230`	`+ // Code that doesn't implement pairing/bonding won't support set/get secret.`
	`231`	`+ // So they'll just get the default fixed IRK.`
	`232`	`+ return 0;`
`231`	`233`	`}`
`232`	`234`	`DEBUG_printf("load_irk: Applying new IRK.\n");`
`233`	`235`	`rc = ble_hs_pvcy_set_our_irk(rand_irk);`