Fix symfony#37740: Cast all Request parameter values to string

Randy Geraads · fabpot · commit d4e2cec1fbea · 2020-08-18T16:07:45.000+02:00
diff --git a/src/Symfony/Component/BrowserKit/Request.php b/src/Symfony/Component/BrowserKit/Request.php
@@ -37,6 +37,11 @@ public function __construct(string $uri, string $method, array $parameters = [],
     {
         $this->uri = $uri;
         $this->method = $method;
+
+        array_walk_recursive($parameters, static function (&$value) {
+            $value = (string) $value;
+        });
+
         $this->parameters = $parameters;
         $this->files = $files;
         $this->cookies = $cookies;
diff --git a/src/Symfony/Component/BrowserKit/Tests/RequestTest.php b/src/Symfony/Component/BrowserKit/Tests/RequestTest.php
@@ -51,4 +51,24 @@ public function testGetServer()
         $request = new Request('http://www.example.com/', 'get', [], [], [], ['foo' => 'bar']);
         $this->assertEquals(['foo' => 'bar'], $request->getServer(), '->getServer() returns the server parameters of the request');
     }
+
+    public function testAllParameterValuesAreConvertedToString(): void
+    {
+        $parameters = [
+            'foo' => 1,
+            'bar' => [
+                'baz' => 2,
+            ],
+        ];
+
+        $expected = [
+            'foo' => '1',
+            'bar' => [
+                'baz' => '2',
+            ],
+        ];
+
+        $request = new Request('http://www.example.com/', 'get', $parameters);
+        $this->assertSame($expected, $request->getParameters());
+    }
 }
