8000 RFC: Add pierreglaser/sklearn_parallel_benchmark to scikit-learn_benchmarks · Issue #16 · jeremiedbb/scikit-learn_benchmarks · GitHub
[go: up one dir, main page]
Skip to content

RFC: Add pierreglaser/sklearn_parallel_benchmark to scikit-learn_benchmarks #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 3 tasks
pierreglaser opened this issue Aug 1, 2019 · 2 comments
Open
1 of 3 tasks

RFC: Add pierreglaser/sklearn_parallel_benchmark to scikit-learn_benchmarks #16

pierreglaser opened this issue Aug 1, 2019 · 2 comments

Comments

@pierreglaser
Copy link

Hi,

This year I created a repository called sklearn_parallel_benchmarks. It benchmarks the performance of many scikit-learn estimators when fitted in parallel, either using threads or processes.

This benchmark suite allowed to spot several regressions, and this led to fixes to scikit-learn master. Examples:

On the other side, it is possible that @jeremiedbb's benchmark suite (this repository) becomes the official benchmark suite of scikit-learn, and eventually gets transfered to the scikit-learn organisation.

I suggest thus to add my benchmark suite to this repository. As those two benchmark suites are still WIP, and that there are still some cleaning to do on both sides, we could first register my benchmark suite as a submodule of scikit-learn_benchmarks, to ensure fast and independent updating of the benchmark suites. Once the two suite converge, we can discuss other vendoring options.

Here is a vague TODO list to begin with:

  • added pierreglaser/sklearn_parallel_benchmarks as a submodule of jeremiedbb/scikit-learn_benchmarks in an experimental branch
  • clean up both repositories
  • add jeremiedbb/scikit-learn_benchmarks to the scikit-learn org
@rth
Copy link
rth commented Apr 7, 2020

Yes, this would be a very good idea.

add jeremiedbb/scikit-learn_benchmarks to the scikit-learn org

Scikit-learn issue about this is scikit-learn/scikit-learn#16723

@jjerphan
< 65D5 /path> Copy link

I guess this PR can be closed thanks to scikit-learn/scikit-learn#17026?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rth @jjerphan @pierreglaser
0