rgbmatrix: validate width= constructor parameter

jepler · jepler · commit f7eefef82ff7 · 2020-09-28T19:00:05.000-05:00
In adafruit#3482, @cwalther noted that, hypothetically, a zero byte allocation could be made in the RGBMatrix constructor. Ensure that width is positive. Height was already checked against the number of RGB pins if it was specified, so zero is ruled out there as well.
diff --git a/shared-bindings/rgbmatrix/RGBMatrix.c b/shared-bindings/rgbmatrix/RGBMatrix.c
@@ -210,6 +210,10 @@ STATIC mp_obj_t rgbmatrix_rgbmatrix_make_new(const mp_obj_type_t *type, size_t n
         }
     }
 
+    if (args[ARG_width] <= 0) {
+        mp_raise_ValueError(translate("width must be greater than zero"));
+    }
+
     preflight_pins_or_throw(clock_pin, rgb_pins, rgb_count, true);
 
     mp_obj_t framebuffer = args[ARG_framebuffer].u_obj;

Original file line number	Diff line number	Diff line change
`@@ -210,6 +210,10 @@ STATIC mp_obj_t rgbmatrix_rgbmatrix_make_new(const mp_obj_type_t *type, size_t n`
`210`	`210`	`}`
`211`	`211`	`}`
`212`	`212`
	`213`	`+ if (args[ARG_width] <= 0) {`
	`214`	`+ mp_raise_ValueError(translate("width must be greater than zero"));`
	`215`	`+ }`
	`216`	`+`
`213`	`217`	`preflight_pins_or_throw(clock_pin, rgb_pins, rgb_count, true);`
`214`	`218`
`215`	`219`	`mp_obj_t framebuffer = args[ARG_framebuffer].u_obj;`