Merge pull request #2 from hathach/tinyusb-update

dhalbert · web-flow · commit 7bfe186c91fc · 2023-03-13T17:21:43.000-04:00
fix rp2040 with new shared irq usb handler
diff --git a/ports/raspberrypi/supervisor/usb.c b/ports/raspberrypi/supervisor/usb.c
@@ -39,15 +39,8 @@ STATIC void _usb_irq_wrapper(void) {
 }
 
 void post_usb_init(void) {
-    irq_set_enabled(USBCTRL_IRQ, false);
-
-    irq_handler_t usb_handler = irq_get_exclusive_handler(USBCTRL_IRQ);
-    if (usb_handler) {
-        irq_remove_handler(USBCTRL_IRQ, usb_handler);
-    }
-    irq_set_exclusive_handler(USBCTRL_IRQ, _usb_irq_wrapper);
-
-    irq_set_enabled(USBCTRL_IRQ, true);
+    irq_add_shared_handler(USBCTRL_IRQ, _usb_irq_wrapper,
+        PICO_SHARED_IRQ_HANDLER_LOWEST_ORDER_PRIORITY);
 
     // There is a small window where the USB interrupt may be handled by the
     // pico-sdk instead of CircuitPython. If that is the case, then we'll have
diff --git a/supervisor/shared/usb/usb.c b/supervisor/shared/usb/usb.c
@@ -225,13 +225,17 @@ void usb_background_schedule(void) {
 }
 
 void usb_irq_handler(int instance) {
+    #if CFG_TUSB_MCU != OPT_MCU_RP2040
+    // For rp2040, IRQ handler is already installed and invoked automatically
     if (instance == CIRCUITPY_USB_DEVICE_INSTANCE) {
         tud_int_handler(instance);
-    } else if (instance == CIRCUITPY_USB_HOST_INSTANCE) {
-        #if CIRCUITPY_USB_HOST
+    }
+    #if CIRCUITPY_USB_HOST
+    else if (instance == CIRCUITPY_USB_HOST_INSTANCE) {
         tuh_int_handler(instance);
-        #endif
     }
+    #endif
+    #endif
 
     usb_background_schedule();
 }

Original file line number	Diff line number	Diff line change
`@@ -225,13 +225,17 @@ void usb_background_schedule(void) {`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`void usb_irq_handler(int instance) {`
	`228`	`+ #if CFG_TUSB_MCU != OPT_MCU_RP2040`
	`229`	`+ // For rp2040, IRQ handler is already installed and invoked automatically`
`228`	`230`	`if (instance == CIRCUITPY_USB_DEVICE_INSTANCE) {`
`229`	`231`	`tud_int_handler(instance);`
`230`		`- } else if (instance == CIRCUITPY_USB_HOST_INSTANCE) {`
`231`		`- #if CIRCUITPY_USB_HOST`
	`232`	`+ }`
	`233`	`+ #if CIRCUITPY_USB_HOST`
	`234`	`+ else if (instance == CIRCUITPY_USB_HOST_INSTANCE) {`
`232`	`235`	`tuh_int_handler(instance);`
`233`		`- #endif`
`234`	`236`	`}`
	`237`	`+ #endif`
	`238`	`+ #endif`
`235`	`239`
`236`	`240`	`usb_background_schedule();`
`237`	`241`	`}`