8000 Fixed tslint errors · jensWorkGit/NativeScript@b12f112 · GitHub
[go: up one dir, main page]
Skip to content

Commit b12f112

Browse files
PanayotCankovPanayotCankov
committed
Fixed tslint errors
1 parent 23658c9 commit b12f112

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

‎apps/app/gallery-app/animations/js-configurable.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import * as animationModule from "ui/animation";
66
import * as colorModule from "color";
77
import * as enums from "ui/enums";
88
import * as frame from "ui/frame";
9-
import * as trace from "trace";
109

1110
export class ViewModel extends observable.Observable {
1211
constructor() {

‎tns-core-modules/ui/animation/animation.android.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import {
33
AnimationBase, Properties, PropertyAnimation, CubicBezierAnimationCurve, AnimationPromise,
44
opacityProperty, backgroundColorProperty, rotateProperty,
55
translateXProperty, translateYProperty,
6-
scaleXProperty, scaleYProperty, Color, traceWrite, traceEnabled, traceCategories, unsetValue
6+
scaleXProperty, scaleYProperty, Color, traceWrite, traceEnabled, traceCategories
77
} from "./animation-common";
88

99
import { CacheLayerType, layout } from "utils/utils";
8000

‎tns-core-modules/ui/core/properties.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ export class CssAnimationProperty<T extends Style, U> {
584584
let prev = this[computedValue];
585585
if (value === unsetValue) {
586586
this[symbol] = unsetValue;
587-
if (this[computedSource] == propertySource) {
587+
if (this[computedSource] === propertySource) {
588588
// Fallback to lower value source.
589589
if (this[styleValue] !== unsetValue) {
590590
this[computedSource] = ValueSource.Local;
@@ -609,9 +609,15 @@ export class CssAnimationProperty<T extends Style, U> {
609609
}
610610
let next = this[computedValue];
611611
if (prev !== next && (!equalityComparer || !equalityComparer(prev, next))) {
612-
valueChanged && valueChanged(this, prev, next);
613-
this.view.nativeView && (this.view[native] = next);
614-
this.hasListeners(eventName) && this.notify({ eventName, object: this, propertyName, value });
612+
if (valueChanged) {
613+
valueChanged(this, prev, next);
614+
}
615+
if (this.view.nativeView) {
616+
this.view[native] = next;
617+
}
618+
if (this.hasListeners(eventName)) {
619+
this.notify({ eventName, object: this, propertyName, value });
620+
}
615621
}
616622
}
617623
}
@@ -637,7 +643,7 @@ export class CssAnimationProperty<T extends Style, U> {
637643
Object.defineProperty(cls.prototype, defaultName, defaultPropertyDescriptor);
638644
Object.defineProperty(cls.prototype, cssName, cssPropertyDescriptor);
639645
Object.defineProperty(cls.prototype, propertyName, stylePropertyDescriptor);
640-
if (options.cssName && options.cssName != options.name) {
646+
if (options.cssName && options.cssName !== options.name) {
641647
Object.defineProperty(cls.prototype, options.cssName, stylePropertyDescriptor);
642648
}
643649
Object.defineProperty(cls.prototype, keyframeName, keyframePropertyDescriptor);

0 commit comments

Comments
 (0)
0