[JENKINS-61290] hard to see why a branch was not inspected - log them #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BranchDiscoveryTrait.java : report into scan log if a branch is ignored (because it is or is-not a source of PR, based on user choice of settings) similarly as proposed and refined for github-branch-source-plugin in jenkinsci/github-branch-source-plugin#284
|
Trying to trigger the rebuild, hoping jenkins-infra is fixed now. |
|
Could you rebase this pr? |
nfalco79
requested changes
Oct 29, 2024
| request.listener().getLogger().format( | ||
| "Ignoring %s because current strategy excludes branches " | ||
| + "that ARE also filed as a pull request%n" | ||
| , head.toString()); |
There was a problem hiding this comment.
As you report in #284 the output log seems to be
Checking branch featureimage/new-nut-configurator
Ignoring SCMHead{'featureimage/new-nut-configurator'} because current strategy excludes branches that ARE also filed as a pull request
Instead of head.toString() could you use a method to produce a readable the branch name as in the above log branch featureimage/new-nut-configurator ?
| @@ -272,6 +278,10 @@ public boolean isExcluded(@NonNull SCMSourceRequest request, @NonNull SCMHead he | |||
| return false; | |||
| } | |||
| } | |||
| request.listener().getLogger().format( | |||
| "Ignoring %s because current strategy excludes branches " | |||
| + "that ARE NOT also filed as a pull request%n" | |||
There was a problem hiding this comment.
please write all words in lower case
| // result blocked together with a later indexed branch | ||
| request.listener().getLogger().format( | ||
| "Ignoring %s because current strategy excludes branches " | ||
| + "that ARE also filed as a pull request%n" |
There was a problem hiding this comment.
please write all words in lower case
|
The issues JENKINS-61290 is referred to github-source-plugin, we can not handle same issue cross multiple plugin to track the version |
|
https://issues.jenkins.io/browse/JENKINS-74784 clones original issue |
|
Manually merged in master with requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
isExcluded()hits into global jenkins log. Alas, I did not find a way to log it into the indexing run's log itself where it would be more appropriate.Solution:
Currently there is no test-case proposed for this change, as this is a small change for trace-logging and no new/changed feature. (And trying to make a test case in the github version of the plugin stalled the PR so I'm a bit fearful of this)