Make github.com repo URLs always https (#133)

mlinksva · jekyllbot · commit 20a35eaede8b · 2018-11-07T09:55:27.000-05:00
Merge pull request 133
diff --git a/lib/jekyll-github-metadata/pages.rb b/lib/jekyll-github-metadata/pages.rb
@@ -53,7 +53,7 @@ def repo_pages_html_url_preview?
         end
 
         def github_url
-          if dotcom?
+          if dotcom? || github_hostname == "github.com"
             "https://github.com".freeze
           else
             "#{scheme}://#{github_hostname}"
diff --git a/spec/repository_spec.rb b/spec/repository_spec.rb
@@ -158,5 +158,27 @@
         end
       end
     end
+    
+    context "in development" do
+      let(:nwo) { "jekyll/jekyll" }
+      
+      it "github.com repo URL always https" do
+        with_env({
+          "GITHUB_HOSTNAME" => "github.com",
+          "PAGES_ENV"       => "development"
+        }) do
+          expect(repo.repository_url).to eql("https://github.com/#{nwo}")
+        end
+      end
+      
+      it "non-github.com repo URL always http" do
+        with_env({
+          "GITHUB_HOSTNAME" => "xyz.example",
+          "PAGES_ENV"       => "development"
+        }) do
+          expect(repo.repository_url).to eql("http://xyz.example/#{nwo}")
+        end
+      end
+    end
   end
 end
