[Serializer] Fix passing null to str_contains()

Erwin Dirks · nicolas-grekas · commit da7d8c0d5fd5 · 2022-02-24T09:36:41.000+01:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -472,7 +472,7 @@ private function validateAndDenormalize(string $currentClass, string $attribute,
             // PHP's json_decode automatically converts Numbers without a decimal part to integers.
             // To circumvent this behavior, integers are converted to floats when denormalizing JSON based formats and when
             // a float is expected.
-            if (Type::BUILTIN_TYPE_FLOAT === $builtinType && \is_int($data) && str_contains($format, JsonEncoder::FORMAT)) {
+            if (Type::BUILTIN_TYPE_FLOAT === $builtinType && \is_int($data) && null !== $format && str_contains($format, JsonEncoder::FORMAT)) {
                 return (float) $data;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -472,7 +472,7 @@ private function validateAndDenormalize(string $currentClass, string $attribute,`
`472`	`472`	`// PHP's json_decode automatically converts Numbers without a decimal part to integers.`
`473`	`473`	`// To circumvent this behavior, integers are converted to floats when denormalizing JSON based formats and when`
`474`	`474`	`// a float is expected.`
`475`		`- if (Type::BUILTIN_TYPE_FLOAT === $builtinType && \is_int($data) && str_contains($format, JsonEncoder::FORMAT)) {`
	`475`	`+ if (Type::BUILTIN_TYPE_FLOAT === $builtinType && \is_int($data) && null !== $format && str_contains($format, JsonEncoder::FORMAT)) {`
`476`	`476`	`return (float) $data;`
`477`	`477`	`}`
`478`	`478`