bug symfony#40655 [Cache] skip storing failure-to-save as misses in ArrayAdapter (nicolas-grekas)

Nyholm · Nyholm · commit 2ceb35a8051e · 2021-03-31T21:20:27.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] skip storing failure-to-save as misses in ArrayAdapter | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#38694 | License | MIT | Doc PR | - In addition to symfony#40645 Commits ------- ba66987 [Cache] skip storing failure-to-save as misses in ArrayAdapter
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/ArrayAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/ArrayAdapterTest.php
@@ -47,6 +47,10 @@ public function testGetValuesHitAndMiss()
         // Miss (should be present as NULL in $values)
         $cache->getItem('bar');
 
+        // Fail (should be missing from $values)
+        $item = $cache->getItem('buz');
+        $cache->save($item->set(function() {}));
+
         $values = $cache->getValues();
 
         $this->assertCount(2, $values);
diff --git a/src/Symfony/Component/Cache/Traits/ArrayTrait.php b/src/Symfony/Component/Cache/Traits/ArrayTrait.php
@@ -145,6 +145,7 @@ private function freeze($value, $key)
             try {
                 $serialized = serialize($value);
             } catch (\Exception $e) {
+                unset($this->values[$key]);
                 $type = \is_object($value) ? \get_class($value) : \gettype($value);
                 $message = sprintf('Failed to save key "{key}" of type %s: ', $type).$e->getMessage();
                 CacheItem::log($this->logger, $message, ['key' => $key, 'exception' => $e]);
