PL/pgSQL RETURN NEXT was leaking converted tuples, causing

jconway · jconway · commit 5a96a0a8cf8c · 2012-05-09T22:51:17.000-07:00
out of memory when looping through large numbers of rows.
Flag the converted tuples to be freed. Complaint and patch
by Joe.
diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
@@ -2243,6 +2243,7 @@ exec_stmt_return_next(PLpgSQL_execstate *estate,
 					{
 						tuple = do_convert_tuple(tuple, tupmap);
 						free_conversion_map(tupmap);
+						free_tuple = true;
 					}
 				}
 				break;

Original file line number	Diff line number	Diff line change
`@@ -2243,6 +2243,7 @@ exec_stmt_return_next(PLpgSQL_execstate *estate,`
`2243`	`2243`	`{`
`2244`	`2244`	`tuple = do_convert_tuple(tuple, tupmap);`
`2245`	`2245`	`free_conversion_map(tupmap);`
	`2246`	`+ free_tuple = true;`
`2246`	`2247`	`}`
`2247`	`2248`	`}`
`2248`	`2249`	`break;`