fix(react): allRoutes cannot triple equal a new array instance (getsentry#3779)

sdemjanenko · web-flow · commit f39834019db0 · 2021-07-07T07:23:40.000-04:00
Running `===` against a newly instantiated array will always return
false. Instead, we should check that `allRoutes` is empty.
diff --git a/packages/react/src/reactrouter.tsx b/packages/react/src/reactrouter.tsx
@@ -65,7 +65,7 @@ function createReactRouterInstrumentation(
   }
 
   function getTransactionName(pathname: string): string {
-    if (allRoutes === [] || !matchPath) {
+    if (allRoutes.length === 0 || !matchPath) {
       return pathname;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ function createReactRouterInstrumentation(`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`function getTransactionName(pathname: string): string {`
`68`		`- if (allRoutes === [] \|\| !matchPath) {`
	`68`	`+ if (allRoutes.length === 0 \|\| !matchPath) {`
`69`	`69`	`return pathname;`
`70`	`70`	`}`
`71`	`71`