Merge pull request sigmavirus24#824 from katharosada/develop

sigmavirus24 · web-flow · commit dd156aa4cf8e · 2018-04-11T07:55:18.000-05:00
Fix equality for IssueEvents without a commit.
diff --git a/AUTHORS.rst b/AUTHORS.rst
@@ -156,3 +156,5 @@ Contributors
 - Becca James (@beccasjames)
 
 - Walid Ziouche (@01walid)
+
+- Katie Bell (@katharosada)
diff --git a/github3/issues/event.py b/github3/issues/event.py
@@ -89,7 +89,7 @@ def _update_attributes(self, event):
 
         self.event = event['event']
         self.id = event['id']
-        self._uniq = self.commit_id
+        self._uniq = self._api
 
     def _repr(self):
         return '<Issue Event [{0} by {1}]>'.format(
diff --git a/tests/unit/test_issues_issue.py b/tests/unit/test_issues_issue.py
@@ -470,7 +470,12 @@ def test_equality(self):
             get_issue_event_example_data(),
             self.session
         )
+        assigned_event = github3.issues.event.IssueEvent(
+            get_issue_assigned_event_example_data(),
+            self.session
+        )
 
+        assert self.instance._uniq is not None
+        assert assigned_event._uniq is not None
         assert self.instance == issue_event
-        issue_event._uniq = 'foo'
-        assert self.instance != issue_event
+        assert self.instance != assigned_event
