8000 DataFrame.rename() mapper arg should be typed instead of any · Issue #345 · javascriptdata/danfojs · GitHub
[go: up one dir, main page]

Skip to content
DataFrame.rename() mapper arg should be typed instead of any #345
Closed
@Devwulf

Description

@Devwulf

In version 1.0.0, the DataFrame.rename() mapper argument is typed as any instead of strongly typed. This caused me to completely miss the fact that the mapper argument is now outside the options argument while migrating to this new version of Danfojs, and it may lead others to do so as well. Wouldn't it be better to type it something like this?

type Mapper = {
    [index: string]: string | number;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0