Clearer messages for when denied test fails

arjantijms · arjantijms · commit 207fe5b9c4db · 2019-11-20T13:06:34.000+01:00
Signed-off-by: arjantijms &lt;arjan.tijms@gmail.com&gt;
diff --git a/servlet/security-deny-uncovered/src/test/java/org/javaee7/servlet/security/deny/uncovered/SecureServletTest.java b/servlet/security-deny-uncovered/src/test/java/org/javaee7/servlet/security/deny/uncovered/SecureServletTest.java
@@ -5,6 +5,7 @@
 import static org.javaee7.ServerOperations.addUsersToContainerIdentityStore;
 import static org.jboss.shrinkwrap.api.ShrinkWrap.create;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.fail;
 
@@ -78,16 +79,21 @@ public void testPostMethod() throws Exception {
         webClient.setCredentialsProvider(correctCreds);
         WebRequest request = new WebRequest(new URL(base + "SecureServlet"), POST);
         
+        TextPage p = null;
         try {
-            TextPage p = webClient.getPage(request);
+            p = webClient.getPage(request);
             System.out.println(p.getContent());
+            
+            assertFalse(
+                "POST method could be called even with deny-uncovered-http-methods", 
+                p.getContent().contains("my POST"));
         } catch (FailingHttpStatusCodeException e) {
             assertNotNull(e);
             assertEquals(403, e.getStatusCode());
             return;
         }
         
-        fail("POST method could be called even with deny-uncovered-http-methods");
+        fail("POST correctly not called, but wrong status code: " + (p != null ? p.getWebResponse().getStatusCode() : -1));
     }
 
     @Test
