8000 Comparing main...spawn-points · java-to-kotlin/kotlinconf-2025-refactoring · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: java-to-kotlin/kotlinconf-2025-refactoring
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: java-to-kotlin/kotlinconf-2025-refactoring
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: spawn-points
Choose a head ref
  • 13 commits
  • 23 files changed
  • 2 contributors

Commits on May 20, 2025

  1. End of ReverseAuction.decideWinner refactor

    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    0f7ec0f View commit details
    Browse the repository at this point in the history

  2. Eliminate unnecessary mutability

    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    96761fa View commit details
    Browse the repository at this point in the history

  3. Make Bid immutable

    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    9f0a8ed View commit details
    Browse the repository at this point in the history

  4. Use strategy for decideWinner

    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    9068258 View commit details
    Browse the repository at this point in the history

  5. Subclasses populate properties by calling superclass constructor

    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    99549fe View commit details
    Browse the repository at this point in the history

  6. Auction inheritance replaced by Strategy pattern

    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    25403b1 View commit details
    Browse the repository at this point in the history

  7. Make Auction.id immutable

    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    dff9045 View commit details
    Browse the repository at this point in the history

  8. Make Auction.bids immutable

    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    b4a9edc View commit details
    Browse the repository at this point in the history

  9. Make Auction.state and winner immutable, to make Auction entirely imm… 

    …utable
    @npryce
    npryce committed May 20, 2025
    Configuration menu
    Copy the full SHA
    e3cd739 View commit details
    Browse the repository at this point in the history

  10. Make Auction.placeBid return Result<Auction, Exception>

    @dmcg
    dmcg committed May 20, 2025
    Configuration menu
    Copy the full SHA
    7ae3a9d View commit details
    Browse the repository at this point in the history

  11. Make AuctionService.placeBid return Result<Auction, Exception>

    @dmcg
    dmcg committed May 20, 2025
    Configuration menu
    Copy the full SHA
    6ff3d1a View commit details
    Browse the repository at this point in the history

  12. Actually return ResponseEntity from AuctionController.recordBid

    @dmcg
    dmcg committed May 20, 2025
    Configuration menu
    Copy the full SHA
    67c2792 View commit details
    Browse the repository at this point in the history

  13. Make the exceptions of placeBid implement a sealed interface so that … 

    …we know what they are
    @dmcg
    dmcg committed May 20, 2025
    Configuration menu
    Copy the full SHA
    52226b1 View commit details
    Browse the repository at this point in the history
Loading
0