collections.5 : Return reference to mutated param

Duncan McGregor · dmcg · commit a7058828cdf9 · 2021-06-25T09:35:04.000+01:00
diff --git a/src/main/java/travelator/Suffering.java b/src/main/java/travelator/Suffering.java
@@ -3,8 +3,8 @@
 import java.util.List;
 
 import static java.util.Comparator.comparing;
-import static travelator.Other.SOME_COMPLICATED_RESULT;
 import static travelator.Collections.sorted;
+import static travelator.Other.SOME_COMPLICATED_RESULT;
 import static travelator.Other.routesFor;
 import static travelator.Routes.getDepartsFrom;
 
@@ -29,12 +29,15 @@ static List<Journey> longestJourneysIn(
 
     public static List<List<Journey>> routesToShowFor(String itineraryId) {
         var routes = routesFor(itineraryId);
-        removeUnbearableRoutes(routes);
+        routes = removeUnbearableRoutes(routes);
         return routes;
     }
 
-    private static void removeUnbearableRoutes(List<List<Journey>> routes) {
+    private static List<List<Journey>> removeUnbearableRoutes
+        (List<List<Journey>> routes
+    ) {
         routes.removeIf(route -> sufferScoreFor(route) > 10);
+        return routes;
     }
 
     private static int sufferScore(
