Fix confusing javadoc documentation for reportLinesUnchanged#186
Merged
wumpz merged 1 commit intojava-diff-utils:masterfrom Apr 3, 2024
Merged
Fix confusing javadoc documentation for reportLinesUnchanged#186wumpz merged 1 commit intojava-diff-utils:masterfrom
wumpz merged 1 commit intojava-diff-utils:masterfrom
Conversation
… which also fixes the typo
This file contains hidden or bidirectional Unicode text that may be interpre
6656
ted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original javadoc comments has problems:
ial"Wrappedchanged"DiffRow.Tags would be absentreportLinesUnchangedis not a flag to omit the lines withDiffRow.Tag.EQUALI spent hours trying to figure out why setting
reportLinesUnchangedtofalsestill reports the lines that are unchanged. I had to go through the source code to figure out what this method was for.