8000 Fixing Turtle examples by elf-pavlik · Pull Request #70 · w3c/activitystreams · GitHub
[go: up one dir, main page]
Skip to content

Fixing Turtle examples #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 2, 2015
Merged

Fixing Turtle examples #70

merged 9 commits into from
Mar 2, 2015

Conversation

elf-pavlik
Copy link
Member

I fixed examples 1 & 3 and would like to get some feedback before moving on with it, so no need to merge it until i fix all the other turtle examples!
you can run

npm test

rel #65

@elf-pavlik
Copy link
Member Author

@jasnell i needed to remove from all examples use of RDF lists in turtle
elf-pavlik@5bb7a30#diff-67bcb8f7a6dfcefb5456db20c189cb5dL1684

@elf-pavlik
Copy link
Member Author

last two examles blocked by #71 and rdf-ext/rdf-ext#17

@elf-pavlik
Copy link
Member Author

after super fast updates to jsonld.js and rdf-ext by their authors, now we have working tests to prove all 24 Turtle examples matching exactly their JSON-LD equivalents 👯
@jasnell please let me know if you would prefer all those commits squashed into a single one!

@jasnell
Copy link
Collaborator
jasnell commented Feb 10, 2015

I'd appreciate if you could squash them down, would make it easier to review. Thank you!

@elf-pavlik
Copy link
Member Author

@jasnell maybe you can just cherry-pick it from elf-pavlik@141059a

@elf-pavlik
Copy link
Member Author

I can also make a new pull request if you find it easier this way...

@elf-pavlik elf-pavlik mentioned this pull request Feb 23, 2015
Closed
@elf-pavlik elf-pavlik changed the title fixing turtle examples Fixing Turtle examples Feb 23, 2015
@elf-pavlik
Copy link
Member Author

squashed commits from this branch also available in PR with fixes for RDFa examples #75

@jasnell
Copy link
Collaborator
jasnell commented Feb 23, 2015

@elf .. thank you. I'll look at getting these merged in next week.

jasnell added a commit that referenced this pull request Mar 2, 2015
@jasnell
Merge pull request #70 from elf-pavlik/tests
aaee3f0 
Fixing Turtle examples
@jasnell jasnell merged commit aaee3f0 into w3c:testing Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elf-pavlik @jasnell
0