8000 abort final GC after some amount of time · jameswei/arangodb@232cdab · GitHub
[go: up one dir, main page]

8000
Skip to content

Commit 232cdab

Browse files
committed
abort final GC after some amount of time
1 parent 07d779e commit 232cdab

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

arangosh/V8Client/arangosh.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2423,9 +2423,11 @@ int main (int argc, char* args[]) {
24232423

24242424
isolate->LowMemoryNotification();
24252425

2426-
// todo 1000 was the old V8-default, is this really good?
2427-
while (! isolate->IdleNotification(1000)) {
2428-
}
2426+
// spend at least 3 seconds in GC
2427+
LOG_DEBUG("entering final garbage collection");
2428+
TRI_RunGarbageCollectionV8(isolate, 3000);
2429+
LOG_DEBUG("final garbage collection completed");
2430+
24292431
localContext->Exit();
24302432
context.Reset();
24312433
}

0 commit comments

Comments
 (0)
0