10BC0 memory: Add first class fields in tracequery params by sujalshah-bit · Pull Request #7375 · jaegertracing/jaeger · GitHub
[go: up one dir, main page]
Skip to content

memory: Add first class fields in tracequery params #7375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

memory: Add first class fields in tracequery params #7375

wants to merge 1 commit into from

Conversation

sujalshah-bit
Copy link
Contributor

Resolves #7063.

Description of the changes

How was this change tested?

Checklist

@codecov Codecov
Copy link
codecov bot commented Jul 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.40%. Comparing base (2d31ced) to head (fbb623f).
⚠️ Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
internal/storage/v2/memory/tenant.go 70.96% 9 Missing ⚠️

❌ Your patch check has failed because the patch coverage (70.96%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7375      +/-   ##
==========================================
- Coverage   96.45%   96.40%   -0.05%     
==========================================
  Files         375      375              
  Lines       22878    22977      +99     
==========================================
+ Hits        22067    22152      +85     
- Misses        613      626      +13     
- Partials      198      199       +1
Flag Coverage Δ
badger_v1 9.06% <ø> (-0.06%) ⬇️
badger_v2 1.71% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v1-manual 11.77% <ø> (-0.07%) ⬇️
cassandra-4.x-v2-auto 1.70% <0.00%> (-0.02%) ⬇️
cassandra-4.x-v2-manual 1.70% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v1-manual 11.77% <ø> (-0.07%) ⬇️
cassandra-5.x-v2-auto 1.70% <0.00%> (-0.02%) ⬇️
cassandra-5.x-v2-manual 1.70% <0.00%> (-0.02%) ⬇️
elasticsearch-6.x-v1 16.72% <ø> (-0.09%) ⬇️
elasticsearch-7.x-v1 16.76% <ø> (-0.09%) ⬇️
elasticsearch-8.x-v1 16.90% <ø> (-0.09%) ⬇️
elasticsearch-8.x-v2 1.71% <0.00%> (-0.11%) ⬇️
elasticsearch-9.x-v2 1.71% <0.00%> (-0.02%) ⬇️
grpc_v1 10.29% <ø> (-0.06%) ⬇️
grpc_v2 1.71% <0.00%> (-0.02%) ⬇️
kafka-3.x-v1 9.22% <ø> (-0.06%) ⬇️
kafka-3.x-v2 1.71% <0.00%> (-0.02%) ⬇️
memory_v2 1.71% <0.00%> (-0.02%) ⬇️
opensearch-1.x-v1 16.81% <ø> (-0.09%) ⬇️
opensearch-2.x-v1 16.81% <ø> (-0.09%) 8000 ⬇️
opensearch-2.x-v2 1.71% <0.00%> (-0.02%) ⬇️
opensearch-3.x-v2 1.80% <0.00%> (+0.07%) ⬆️
query 1.71% <0.00%> (-0.02%) ⬇️
tailsampling-processor 0.47% <0.00%> (-0.01%) ⬇️
unittests 95.39% <70.96%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro
Copy link
Member

It's not obvious to me that the search parameters struct needs to be changed. The issue is suggesting that the user would still be using the Tags textbox to search by top level fields, so the input will already be provided to the backend implementation in the form of the Tags collection. Changing the struct will be an invasive change, including changing the Remote Storage API, I am not sure it's worth it, the Tags collection is adequate to pass the information. It's the implementation in the storage backends that needs to adapt accordingly.

@sujalshah-bit
memory: Add first class fields in tracequery params
fbb623f 
Resolves jaegertracing#7063.

Signed-off-by: Sujal Shah <sujalshah28092004@gmail.com>
@sujalshah-bit sujalshah-bit force-pushed the implement_first_class_fields branch from bb70988 to fbb623f Compare July 29, 2025 10:24
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time.

@github-actions github-actions bot added the stale The issue/PR has become stale and may be auto-closed label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale The issue/PR has become stale and may be auto-closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support OTLP first class fields in the search
2 participants
@sujalshah-bit @yurishkuro
0