17.multilingual-bot suggested corrections

Tracy Boehrer · Tracy Boehrer · commit 52a1d84ab38c · 2019-11-11T12:22:52.000-06:00
diff --git a/samples/17.multilingual-bot/app.py b/samples/17.multilingual-bot/app.py
@@ -32,7 +32,7 @@
 
 
 # Catch-all for errors.
-async def on_error(self, context: TurnContext, error: Exception):
+async def on_error(context: TurnContext, error: Exception):
     # This check writes out errors to console log .vs. app insights.
     # NOTE: In production environment, you should consider logging this to Azure
     #       application insights.
@@ -55,7 +55,7 @@ async def on_error(self, context: TurnContext, error: Exception):
         # Send a trace activity, which will be displayed in Bot Framework Emulator
         await context.send_activity(trace_activity)
 
-ADAPTER.on_turn_error = MethodType(on_error, ADAPTER)
+ADAPTER.on_turn_error = on_error
 
 # Create MemoryStorage and state
 MEMORY = MemoryStorage()
diff --git a/samples/17.multilingual-bot/bots/multilingual_bot.py b/samples/17.multilingual-bot/bots/multilingual_bot.py
@@ -28,7 +28,7 @@ def __init__(self, user_state: UserState):
         self.language_preference_accessor = self.user_state.create_property("LanguagePreference")
 
     async def on_members_added_activity(
-        self, members_added: [ChannelAccount], turn_context: TurnContext
+            self, members_added: [ChannelAccount], turn_context: TurnContext
     ):
         # Greet anyone that was not the target (recipient) of this message.
         # To learn more about Adaptive Cards, see https://aka.ms/msbot-adaptivecards for more details.
@@ -99,8 +99,7 @@ def _is_language_change_requested(self, utterance: str) -> bool:
             return False
 
         utterance = utterance.lower()
-        return utterance == TranslationSettings.english_spanish.value \
-            or utterance == TranslationSettings.english_english.value \
-            or utterance == TranslationSettings.spanish_spanish.value \
-            or utterance == TranslationSettings.spanish_english.value
-
+        return (utterance == TranslationSettings.english_spanish.value
+                or utterance == TranslationSettings.english_english.value
+                or utterance == TranslationSettings.spanish_spanish.value
+                or utterance == TranslationSettings.spanish_english.value)
diff --git a/samples/17.multilingual-bot/translation/microsoft_translator.py b/samples/17.multilingual-bot/translation/microsoft_translator.py
@@ -33,7 +33,7 @@ async def translate(self, text_input, language_output):
             'text': text_input
         }]
         response = requests.post(constructed_url, headers=headers, json=body)
-        j = response.json()
+        json_response = response.json()
 
         # for this sample, return the first translation
-        return j[0]["translations"][0]["text"]
+        return json_response[0]["translations"][0]["text"]
