Add SkillValidation Claims tests (microsoft#1383)

EricDahlvang · web-flow · commit 3bfdc9fdfb55 · 2020-09-08T11:52:32.000-07:00
* Add SkillValidation Claims tests

* fix skill validation tests
diff --git a/libraries/botframework-connector/tests/test_auth.py b/libraries/botframework-connector/tests/test_auth.py
@@ -62,7 +62,6 @@ async def test_claims_validation(self):
         # No validator should pass.
         await JwtTokenValidation.validate_claims(default_auth_config, claims)
 
-        # ClaimsValidator configured but no exception should pass.
         mock_validator = Mock()
         auth_with_validator = AuthenticationConfiguration(
             claims_validator=mock_validator
@@ -75,6 +74,34 @@ async def test_claims_validation(self):
 
         assert "Invalid claims." in str(excinfo.value)
 
+        # No validator with not skill cliams should pass.
+        default_auth_config.claims_validator = None
+        claims: List[Dict] = {
+            AuthenticationConstants.VERSION_CLAIM: "1.0",
+            AuthenticationConstants.AUDIENCE_CLAIM: "this_bot_id",
+            AuthenticationConstants.APP_ID_CLAIM: "this_bot_id",  # Skill claims aud!=azp
+        }
+
+        await JwtTokenValidation.validate_claims(default_auth_config, claims)
+
+        # No validator with skill cliams should fail.
+        claims: List[Dict] = {
+            AuthenticationConstants.VERSION_CLAIM: "1.0",
+            AuthenticationConstants.AUDIENCE_CLAIM: "this_bot_id",
+            AuthenticationConstants.APP_ID_CLAIM: "not_this_bot_id",  # Skill claims aud!=azp
+        }
+
+        mock_validator.side_effect = PermissionError(
+            "Unauthorized Access. Request is not authorized. Skill Claims require validation."
+        )
+        with pytest.raises(PermissionError) as excinfo_skill:
+            await JwtTokenValidation.validate_claims(auth_with_validator, claims)
+
+        assert (
+            "Unauthorized Access. Request is not authorized. Skill Claims require validation."
+            in str(excinfo_skill.value)
+        )
+
     @pytest.mark.asyncio
     async def test_connector_auth_header_correct_app_id_and_service_url_should_validate(
         self,
