8000 Add todo · iskode/dataframe-api@6010ae7 · GitHub
[go: up one dir, main page]

Skip to content

Commit 6010ae7

Browse files
committed
Add todo
1 parent 2c4a846 commit 6010ae7

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

protocol/pandas_implementation.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,8 @@ def get_data_buffer(self) -> Tuple[_PandasBuffer, Any]: # Any is for self.dtype
511511
# Marshal the strings from a NumPy object array into a byte array
512512
buf = self._col.to_numpy()
513513
b = bytearray()
514+
515+
# TODO: this for-loop is slow; can be implemented in Cython/C/C++ later
514516
for i in range(buf.size):
515517
if type(buf[i]) == str:
516518
b.extend(buf[i].encode(encoding="utf-8"))

0 commit comments

Comments
 (0)
0