Pipe password through to Update User (tableau#75)

t8y8 · web-flow · commit 5ac17ec75325 · 2016-10-25T17:25:41.000-05:00
Update User supports updating a password but we were never passing it through to the serializer. We don't want to keep the password around in the model (and it's never returned from Server) so let's just add it to the update function.

* add `password=None` to `users.update()`
* remove `UserItem.password` and all associated tests -- it doesn't do anything
diff --git a/tableauserverclient/models/user_item.py b/tableauserverclient/models/user_item.py
@@ -28,7 +28,6 @@ def __init__(self, name, site_role, auth_setting=None):
         self._workbooks = None
         self.email = None
         self.fullname = None
-        self.password = None
         self.name = name
         self.site_role = site_role
         self.auth_setting = auth_setting
diff --git a/tableauserverclient/server/endpoint/users_endpoint.py b/tableauserverclient/server/endpoint/users_endpoint.py
@@ -36,13 +36,13 @@ def get_by_id(self, user_id):
         return UserItem.from_response(server_response.content).pop()
 
     # Update user
-    def update(self, user_item):
+    def update(self, user_item, password=None):
         if not user_item.id:
             error = "User item missing ID."
             raise MissingRequiredFieldError(error)
 
         url = "{0}/{1}".format(self.baseurl, user_item.id)
-        update_req = RequestFactory.User.update_req(user_item)
+        update_req = RequestFactory.User.update_req(user_item, password)
         server_response = self.put_request(url, update_req)
         logger.info('Updated user item (ID: {0})'.format(user_item.id))
         updated_item = copy.copy(user_item)
diff --git a/tableauserverclient/server/request_factory.py b/tableauserverclient/server/request_factory.py
@@ -233,7 +233,7 @@ def add_req(self, tag_set):
 
 
 class UserRequest(object):
-    def update_req(self, user_item, password=''):
+    def update_req(self, user_item, password):
         xml_request = ET.Element('tsRequest')
         user_element = ET.SubElement(xml_request, 'user')
         if user_item.fullname:
diff --git a/test/test_user.py b/test/test_user.py
@@ -87,7 +87,6 @@ def test_update(self):
             single_user.name = 'Cassie'
             single_user.fullname = 'Cassie'
             single_user.email = 'cassie@email.com'
-            single_user.password = 'password'
             single_user = self.server.users.update(single_user)
 
         self.assertEqual('Cassie', single_user.name)
