Autobalance #14081

jb-leger · 2023-05-18T17:38:36Z

Carreau · 2023-06-02T08:43:19Z

IPython/core/inputtransformer2.py

+
+# only for type checking, do not import this, it lead to a circular
+# import
+if False:


You can do

from typing import TYPE_CHECKING ... if TYPE_CHECKING:

fixed in 10f3017.

Carreau · 2023-06-02T08:45:02Z

IPython/core/interactiveshell.py

+        symbols are added in the begin of the expression, and closings symbols
+        at the end of the line. E.g. `1+2)/2]*(2+3` becomes `[(1+2)/2]*(2+3)`.
+        """,
+    ).tag(config=True)


Carreau · 2023-06-02T08:53:51Z

IPython/core/inputtransformer2.py

+    shell = kwargs.get("shell")
+    display = kwargs.get("display", False)


I see you are adding kwargs everywhere to get shell and display here, but that will break API of external transforms that don't take a kwargs. So we may wan to have a

class Autobalancer: def __init__(self, shell): .... def __call__(...):

Very good idea, thank you. This solution is a lot less intrusive. Done in 79a23bf.

Carreau · 2023-06-02T08:54:38Z

IPython/core/inputtransformer2.py

@@ -579,6 +658,7 @@ def __init__(self):
        ]
        self.line_transforms = [
            cell_magic,
+            autobalance,


And here you should be able to have Autobalancer(shell)

Continuation of last thread. Done in 79a23bf.

jb-leger force-pushed the autobalance branch from 1dd9948 to 4eb3ae8 Compare May 19, 2023 09:32

jb-leger added 4 commits May 19, 2023 11:53

Pass the shell instance to the TransformerManager

2f5286e

Pass the shell and display indication from the TransformerManager to …

95fc928

…the transform functions

Add tranformation for autobalance [{()}]

86e13a0

define magic for controlling autobalance

eef46e8

jb-leger force-pushed the autobalance branch from 4eb3ae8 to eef46e8 Compare May 19, 2023 09:54

Carreau reviewed Jun 2, 2023

View reviewed changes

jb-leger added 4 commits June 12, 2023 17:08

use typing.TYPE_CHECKING to prevent import

10f3017

autobalance: use callable class to store the shell and do not use kwargs

79a23bf

autobalance: make AutoBalancer usable without shell with default beha…

b3c3de5

…vior

autobalance: add tests

1630c25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autobalance #14081

Autobalance #14081

Autobalance #14081

Are you sure you want to change the base?

Autobalance #14081

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment