8000 fix: throw if asked to delete a block we don't have by achingbrain · Pull Request #88 · ipfs/js-ipfs-block-service · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

fix: throw if asked to delete a block we don't have #88

Merged
merged 3 commits into from
Apr 16, 2020
Merged

fix: throw if asked to delete a block we don't have #88

merged 3 commits into from
Apr 16, 2020

Conversation

achingbrain
Copy link
Member

This is to be consistent with go-IPFS

BREAKING CHANGE:

bs.delete(cid) used to ignore mystery CIDs, now it throws.

@achingbrain
fix: throw if asked to delete a block we don't have
cf04857 
This is to be consistent with go-IPFS

BREAKING CHANGE:

`bs.delete(cid)` used to ignore mystery CIDs, now it throws.
@achingbrain achingbrain requested a review from dirkmc October 4, 2019 16:54
@achingbrain achingbrain requested a review from vmx April 15, 2020 10:04
vmx
vmx approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member
@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry that this one slipped my attention.

@vmx vmx merged commit 4ffb28c into master Apr 16, 2020
@vmx vmx deleted the throw-if-asked-to-delete-non-existent-block branch April 16, 2020 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dirkmc dirkmc Awaiting requested review from dirkmc

2 more reviewers

@vmx vmx vmx approved these changes

@alanshaw alanshaw alanshaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@achingbrain @vmx @alanshaw
0