feat(eslint-plugin): [ban-types] tighten defaults

bradzacher · web-flow · commit 376145b14412 · 2019-08-13T09:36:26.000-07:00
`Record<string, any>` is not typesafe, so we shouldn't suggest it as the default fixer. Additionally, using `any` causes errors via the `no-explicit-any` rule. `Record<string, unknown>` is safe because you have to use type guards to actually use the value. Also add handling for `object`; it wasn't added because I didn't think about the fact that it's not fixing `Object` -> `object` like the rest of the fixers. Fixes typescript-eslint#842
diff --git a/packages/eslint-plugin/src/rules/ban-types.ts b/packages/eslint-plugin/src/rules/ban-types.ts
@@ -96,8 +96,12 @@ export default util.createRule<Options, MessageIds>({
           fixWith: 'number',
         },
         Object: {
-          message: 'Use Record<string, any> instead',
-          fixWith: 'Record<string, any>',
+          message: 'Object is not type safe, use Record<string, unknown> instead',
+          fixWith: 'Record<string, unknown>',
+        },
+        object: {
+          message: 'Object is not type safe, use Record<string, unknown> instead',
+          fixWith: 'Record<string, unknown>',
         },
         Symbol: {
           message: 'Use symbol instead',
