Fix multi process collision by initializing pid variable in master process (prometheus#192)

aimestereo · brian-brazil · commit d858f0d39536 · 2017-09-03T08:07:42.000+01:00
diff --git a/prometheus_client/core.py b/prometheus_client/core.py
@@ -395,6 +395,7 @@ def close(self):
 def _MultiProcessValue(_pidFunc=os.getpid):
     files = {}
     values = []
+    pid = {'value': _pidFunc()}
     # Use a single global lock when in multi-processing mode
     # as we presume this means there is no threading going on.
     # This avoids the need to also have mutexes in __MmapDict.
@@ -413,22 +414,23 @@ def __init__(self, typ, metric_name, name, labelnames, labelvalues, multiprocess
 
 
         def __reset(self):
-            self._pid = _pidFunc()
             typ, metric_name, name, labelnames, labelvalues, multiprocess_mode = self._params
             if typ == 'gauge':
                 file_prefix = typ + '_' +  multiprocess_mode
             else:
                 file_prefix = typ
             if file_prefix not in files:
                 filename = os.path.join(
-                        os.environ['prometheus_multiproc_dir'], '{0}_{1}.db'.format(file_prefix, self._pid))
+                        os.environ['prometheus_multiproc_dir'], '{0}_{1}.db'.format(file_prefix, pid['value']))
                 files[file_prefix] = _MmapedDict(filename)
             self._file = files[file_prefix]
             self._key = json.dumps((metric_name, name, labelnames, labelvalues))
             self._value = self._file.read_value(self._key)
 
         def __check_for_pid_change(self):
-            if self._pid != _pidFunc():
+            actual_pid = _pidFunc()
+            if pid['value'] != actual_pid:
+                pid['value'] = actual_pid
                 # There has been a fork(), reset all the values.
                 for f in files.values():
                     f.close()
