8000 Drop custom json.dumps logic · Issue #80 · influxdata/influxdb-python · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.
This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Drop custom json.dumps logic #80
@jonashaag

Description

@jonashaag

https://github.com/influxdb/influxdb-python/blob/df7fa9646b56a775c0494aadb3ea1ae41deb1ed8/influxdb/client.py#L143

This code could be replaced by just using request's json=... keyword argument, which is converted to a JSON string inside requests. This would require that all occurences of data=...somedict... in the code be replaced by json=...somedict....

There actually doesn't seem to be any case of data being a string in the code base. This means that all the logic testing for str could be stripped from the client and the tests.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0