Well, I am not a huge fan of simply adapting the test suite so that the tests pass. Something must have triggered the type change and in some tests types seem to be inconsistent.

See, for example, the following:

======================================================================
FAIL: test_get_list_series_and_delete (influxdb.tests.server_tests.client_test_with_server.CommonTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/babilen/src/github.com/influxdb/influxdb-python/influxdb/tests/server_tests/client_test_with_server.py", line 480, in test_get_list_series_and_delete
    rsp
AssertionError: Lists differ: [{'name': 'cpu_load_short', 't... != [{'name': 'results', 'tags': [...

First differing element 0:
{'name': 'cpu_load_short', 'tags': [{'_key': 'cpu_load_short,host=server01,region=us-west', 'host': 'server01', 'region': 'us-west'}]}
{'name': 'results', 'tags': [{u'key': u'cpu_load_short,host=server01,region=us-west'}]}

- [{'name': 'cpu_load_short',
+ [{'name': 'results',
-   'tags': [{'_key': 'cpu_load_short,host=server01,region=us-west',
?              -                                                   ^

+   'tags': [{u'key': u'cpu_load_short,host=server01,region=us-west'}]}]
?             +       +                                             ^^^^

-             'host': 'server01',
-             'region': 'us-west'}]}]
-------------------- >> begin captured logging << --------------------
requests.packages.urllib3.connectionpool: DEBUG: "GET /query?db=db&q=CREATE+DATABASE+%22db%22 HTTP/1.1" 200 40
requests.packages.urllib3.connectionpool: DEBUG: "POST /write?db=db HTTP/1.1" 204 0
requests.packages.urllib3.connectionpool: DEBUG: "GET /query?db=db&q=SHOW+SERIES HTTP/1.1" 200 116
--------------------- >> end captured logging << ---------------------

where we see a mixture of unicode and str.

It appears as if points and tags are now returned as unicode, but I am not sure why or if this is the behaviour we want. The inconsistency is, however, rather suboptimal.

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions