Fix List.removeAfter() bug

Alexandre VICTOOR · Alexandre VICTOOR · commit d2192188a0b9 · 2024-10-27T19:16:52.000+01:00
diff --git a/__tests__/List.ts b/__tests__/List.ts
@@ -722,6 +722,11 @@ describe('List', () => {
     expect(o.get(0)).toBe('f');
   });
 
+  it('works with push and insert without phantom values', () => {
+    const v = List.of().set(287, 287).push(42).insert(33, 33);
+    expect(v.toJS().filter(item => item === 287)).toHaveLength(1);
+  });
+
   // TODO: assert that findIndex only calls the function as much as it needs to.
 
   it('forEach iterates in the correct order', () => {
diff --git a/src/List.js b/src/List.js
@@ -304,7 +304,10 @@ class VNode {
   }
 
   removeAfter(ownerID, level, index) {
-    if (index === (level ? 1 << level : 0) || this.array.length === 0) {
+    if (
+      index === (level ? 1 << (level + 1) : SIZE) - 1 ||
+      this.array.length === 0
+    ) {
       return this;
     }
     const sizeIndex = ((index - 1) >>> level) & MASK;

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,10 @@ class VNode {`
`304`	`304`	`}`
`305`	`305`
`306`	`306`	`removeAfter(ownerID, level, index) {`
`307`		`- if (index === (level ? 1 << level : 0) \|\| this.array.length === 0) {`
	`307`	`+ if (`
	`308`	`+ index === (level ? 1 << (level + 1) : SIZE) - 1 \|\|`
	`309`	`+ this.array.length === 0`
	`310`	`+ ) {`
`308`	`311`	`return this;`
`309`	`312`	`}`
`310`	`313`	`const sizeIndex = ((index - 1) >>> level) & MASK;`