8000 Fix Set.fromKeys types with Map constructor in TS 5.0 · immutable-js/immutable-js@5a8b46a · GitHub
[go: up one dir, main page]

Skip to content

Commit 5a8b46a

Browse files
committed
Fix Set.fromKeys types with Map constructor in TS 5.0
1 parent 4370259 commit 5a8b46a

File tree

5 files changed

+16
-12
lines changed

5 files changed

+16
-12
lines changed

package-lock.json

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
"transducers-js": "0.4.174",
123123
"tslint": "6.1.3",
124124
"tslint-config-prettier": "1.18.0",
125-
"typescript": "^4.9",
125+
"typescript": "5.0",
126126
"uglify-js": "3.11.1",
127127
"uglify-save-license": "0.4.1"
128128
}

type-definitions/immutable.d.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1713,6 +1713,8 @@ declare namespace Immutable {
17131713
* `Set.fromKeys()` creates a new immutable Set containing the keys from
17141714
* this Collection or JavaScript Object.
17151715
*/
1716+
function fromKeys<T>(iter: Collection.Keyed<T, unknown>): Set<T>;
1717+
// tslint:disable-next-line unified-signatures
17161718
function fromKeys<T>(iter: Collection<T, unknown>): Set<T>;
17171719
function fromKeys(obj: { [key: string]: unknown }): Set<string>;
17181720

@@ -1936,6 +1938,8 @@ declare namespace Immutable {
19361938
* `OrderedSet.fromKeys()` creates a new immutable OrderedSet containing
19371939
* the keys from this Collection or JavaScript Object.
19381940
*/
1941+
function fromKeys<T>(iter: Collection.Keyed<T, unknown>): OrderedSet<T>;
1942+
// tslint:disable-next-line unified-signatures
19391943
function fromKeys<T>(iter: Collection<T, unknown>): OrderedSet<T>;
19401944
function fromKeys(obj: { [key: string]: unknown }): OrderedSet<string>;
19411945
}

type-definitions/ts-tests/ordered-set.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ import { OrderedSet, Map } from 'immutable';
4242
{
4343
// .fromKeys
4444

45-
// $ExpectType OrderedSet<string>
45+
// $ExpectType OrderedSet<number>
4646
OrderedSet.fromKeys(Map<number, string>());
4747

4848
// $ExpectType OrderedSet<number>

type-definitions/ts-tests/set.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Set, Map } from 'immutable';
1+
import { Set, Map, Collection } from 'immutable';
22

33
{
44
// #constructor
@@ -39,7 +39,7 @@ import { Set, Map } from 'immutable';
3939
{
4040
// .fromKeys
4141

42-
// $ExpectType Set<string>
42+
// $ExpectType Set<number>
4343
Set.fromKeys(Map<number, string>());
4444

4545
// $ExpectType Set<number>

0 commit comments

Comments
 (0)
0