Pass on muted parameter and add test to ensure no regressions

ilanbiala · ilanbiala · commit fb43f65b2f49 · 2017-06-02T10:59:18.000-07:00
diff --git a/tests/unit/twiml/test_voice_response.py b/tests/unit/twiml/test_voice_response.py
@@ -333,6 +333,25 @@ def test_conference(self):
             '<?xml version="1.0" encoding="UTF-8"?><Response><Dial><Conference beep="false" endConferenceOnExit="true" startConferenceOnEnter="true" waitUrl="">TestConferenceAttributes</Conference></Dial></Response>'
         )
 
+    def test_muted_conference(self):
+        d = Dial()
+        d.conference(
+            'TestConferenceMutedAttribute',
+            beep=False,
+            muted=True,
+            wait_url='',
+            start_conference_on_enter=True,
+            end_conference_on_exit=True
+        )
+
+        r = VoiceResponse()
+        r.append(d)
+
+        assert_equal(
+            self.strip(r),
+            '<?xml version="1.0" encoding="UTF-8"?><Response><Dial><Conference beep="false" endConferenceOnExit="true" muted="true" startConferenceOnEnter="true" waitUrl="">TestConferenceMutedAttribute</Conference></Dial></Response>'
+        )
+
 
 class TestQueue(TwilioTest):
 
diff --git a/twilio/http/validation_client.py b/twilio/http/validation_client.py
@@ -1,4 +1,4 @@
-from urlparse import urlparse
+from urllib.parse import urlparse
 
 from collections import namedtuple
 
diff --git a/twilio/twiml/voice_response.py b/twilio/twiml/voice_response.py
@@ -392,6 +392,7 @@ def conference(self,
         """
         return self.append(Conference(
             name,
+            muted=muted,
             start_conference_on_enter=start_conference_on_enter,
             end_conference_on_exit=end_conference_on_exit,
             max_participants=max_participants,

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-from urlparse import urlparse`
	`1`	`+from urllib.parse import urlparse`
`2`	`2`
`3`	`3`	`from collections import namedtuple`
`4`	`4`