MSVC: Rebuild spiexceptions.h when out of date.

nmisch · nmisch · commit ab8eae0bb5a1 · 2017-11-12T18:44:38.000-08:00
Also, add a warning to catch future instances of naming a nonexistent
file as a prerequisite.  Back-patch to 9.3 (all supported versions).
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
@@ -90,6 +90,7 @@ sub DeterminePlatform
 sub IsNewer
 {
 	my ($newfile, $oldfile) = @_;
+	-e $oldfile or warn "source file \"$oldfile\" does not exist";
 	if (   $oldfile ne 'src\tools\msvc\config.pl'
 		&& $oldfile ne 'src\tools\msvc\config_default.pl')
 	{
@@ -308,7 +309,7 @@ s{PG_VERSION_STR "[^"]+"}{__STRINGIFY(x) #x\n#define __STRINGIFY2(z) __STRINGIFY
 	if ($self->{options}->{python}
 		&& IsNewer(
 			'src\pl\plpython\spiexceptions.h',
-			'src\include\backend\errcodes.txt'))
+			'src\backend\utils\errcodes.txt'))
 	{
 		print "Generating spiexceptions.h...\n";
 		system(

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,7 @@ sub DeterminePlatform`
`90`	`90`	`sub IsNewer`
`91`	`91`	`{`
`92`	`92`	`my ($newfile, $oldfile) = @_;`
	`93`	`+ -e $oldfile or warn "source file \"$oldfile\" does not exist";`
`93`	`94`	`if ( $oldfile ne 'src\tools\msvc\config.pl'`
`94`	`95`	`&& $oldfile ne 'src\tools\msvc\config_default.pl')`
`95`	`96`	`{`
`@@ -308,7 +309,7 @@ s{PG_VERSION_STR "[^"]+"}{__STRINGIFY(x) #x\n#define __STRINGIFY2(z) __STRINGIFY`
`308`	`309`	`if ($self->{options}->{python}`
`309`	`310`	`&& IsNewer(`
`310`	`311`	`'src\pl\plpython\spiexceptions.h',`
`311`		`- 'src\include\backend\errcodes.txt'))`
	`312`	`+ 'src\backend\utils\errcodes.txt'))`
`312`	`313`	`{`
`313`	`314`	`print "Generating spiexceptions.h...\n";`
`314`	`315`	`system(`