Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 8 commits
- 16 files changed
- 7 contributors
Commits on Aug 31, 2021
-
Update client.cpp (cpp-redis#80)
MY_PATH/cpp_redis-src/sources/core/client.cpp: In member function ‘void cpp_redis::client::sleep_before_next_reconnect_attempt()’: MY_PATH/cpp_redis-src/sources/core/client.cpp:347:21: error: ‘sleep_for’ is not a member of ‘std::this_thread’ 347 | std::this_thread::sleep_for(std::chrono::milliseconds(m_reconnect_interval_msecs));
Commits on Sep 2, 2022
-
fix example cc_binary:example_cpp_redis_client build failed (cpp-redi…
…s#93) * fix example cc_binary:example_cpp_redis_client build failed * Update WORKSPACE
Commits on Oct 15, 2022
-
* cmake: clean up CMakeLists.txt - Move project definition to the top and add VERSION - Remove obsolete variable PROJECT and use standard PROJECT_NAME - Require a more modern version of CMake - Use CMAKE_CXX_STANDARD instead of manually adding -std=c++11 - Only include ExternalProject if required * cmake: indent CMakeLists.txt according to best practices Rules from: https://community.kde.org/Policies/CMake_Coding_Style#Indentation Since rest of the codebase doesn't use tabs, CMake files shouldn't either. * cmake: make the main target a shared library CMake sets PIC automatically for shared libraries and modules. * cmake: set policy CMP0048 to NEW This enables PROJECT_* variables. * cmake: use add_compile_options() instead of CMAKE_CXX_FLAGS * cmake: move source handling to sources.cmake Don't add headers as direct dependencies to targets. Compilers can detect header dependencies and manage recompilation automatically. Use list(APPEND ...) in favor of the less explicit set(var ${var} ...). Downcase variable names to separate project local variables to CMake vars. * cmake use FindThreads.cmake to select thread implementation * cmake: downcase tacopie_* variables * cmake: remove reference to obsolete variable SOURCES * cmake: explicitly customize tacopie build Set configuration parameters before adding tacopie subdirectory to force wanted behavior. * cmake: document build parameters options * cmake: remove resetting BUILD_EXAMPLES * cmake: downcase install script file() calls * cmake: use googletest 1.10.0 from a submodule A common use case is to integrate libraries as git submodules and a single project might have multiple modules each with test dependencies to gtest. Usually the top level project configures gtest, propagating the target to it's submodules. This is preferable to the case where each submodule uses ExternalProject to build & install gtest in a custom location with possibly arbitrary target names (googletest, gtest, <foobar>_gtest, etc.) as this can easily lead to multiple gtest builds. As a solution check if gtest (which is defined by googletest's build files) is an existing target to determine if project's own googletest submodule should be added to the build. Either way the subsequent add_subdirectory() tests will have a target "gtest" to link against. Various INTERFACE flags will take care of the rest. A further improvement is to add "${PROJECT_NAME}::" as a prefix to the tests. This helps when cpp_redis is a part of a larger project and (for any reason) developers want to run cpp_redis' tests only using "ctest -R cpp_redis". * cmake: remove matching conditions from endifs They make maintaining the file extremely frustrating as they break all the time. AFAIK the style if (<condition>) endif (<condition>) is rarely seen anymore. * cmake: add includes as public interface include directories * update tacopie submodule * cmake: move tacopie configuration above main target * cmake: use PROJECT_NAME when configuring project pkg-config file * cmake: add different include dirs depending on build/install state When building the include directories should be absolute paths, but obviously when installing / exporting the paths should be relative. * cmake: install via install(TARGETS) - add SOVERSION and RESOURCE properties The former results in a symlink during installation phase (on platforms that support such things) and the latter makes it easier to install extra stuff in install(TARGETS). - add EXPORT target name - remove unnecessary and harmful install(DIRECTORY) calls * update tacopie submodule Support for EXPORT_TARGET_NAME and better install support all around. * cmake: remove deprecated features Using tacopie from system libdir might be good feature to have, but the current implementation is buggy. Add it properly later using pkgconfig or CMake imports. * cmake: add install(EXPORT) The call will automatically install the project configuration as an importable file called lib/cpp_redis/cpp_redis.cmake. The file will configure installed targets as imports so that they can be used like regular CMake targets. * ci: travis: download a more recent cmake * ci: travis: allow existing deps dir * ci: travis: calculate md5sum in a portable way * ci: travis: disable md5 check and trust https certificate * ci: travis: export custom cmake dir in PATH * cmake: add guards against unknown policies Allow the configuration to go slightly further with older versions. * ci: travis: print cmake path & version * cmake: refactor project() call 8000 to support older versions Also move the cmake_minimum_required() at the top of the file as per cmake official recommendations. * ci: travis: fix cmake path settings for osx CMake's OSx tarball contents are different than on Linux. Handle those in travis. * ci: travis: fix syntax error in if clause * ci: travis: extract functionality into scripts Travis build file was getting harder to read. Extract the same steps into scripts. Most of the files need to be sourced as they conditionally set environment variables. * ci: travis: run pre-build configuration code from scripts * install-cmake.sh: remove stale variable references * ci: travis: print env before build * install-cmake.sh: simplify install dir handling Tar creates a directory called ${CMAKE_FILE}, just use that in ${CMAKE_INSTALL_DIR}. * ci: travis: list CMAKE_INSTALL_DIR contents * install-cmake: fix mkdir param After the last change CMAKE_INSTALL_DIR was defined in terms of CMAKE_DOWNLOAD_DIR. Co-authored-by: Henrik Lindblom <henrik.lindblom@vaisala.com> Co-authored-by: Nick Atkins <nbatkins@gmail.com>
3 people authoredOct 15, 2022 -
-
-
Bump tacopie from
0a13c7ato6a0cfca(cpp-redis#102)Bumps [tacopie](https://github.com/cpp-redis/tacopie) from `0a13c7a` to `6a0cfca`. - [Release notes](https://github.com/cpp-redis/tacopie/releases) - [Commits](cpp-redis/tacopie@0a13c7a...6a0cfca) --- updated-dependencies: - dependency-name: tacopie dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-
Add count for XREVRANGE (cpp-redis#89)
Co-authored-by: Nick Atkins <nbatkins@gmail.com>
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master