8000 [Type hint] PNDM pipeline by daspartho · Pull Request #327 · huggingface/diffusers · GitHub
[go: up one dir, main page]
Skip to content

[Type hint] PNDM pipeline #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2022
Merged

[Type hint] PNDM pipeline #327

merged 3 commits into from
Sep 2, 2022

Conversation

daspartho
Copy link
Contributor

Based on 35. and 36. of issue #287

@anton-l would you mind checking it? Thanks : )

@HuggingFaceDocBuilderDev
Copy link
HuggingFaceDocBuilderDev commented Sep 1, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@anton-l
Copy link
Member
anton-l commented Sep 2, 2022

Hi @daspartho, thanks for the contribution!
Looks like your make style command made some extra changes to unrelated files due to a wrong black version. We use black==22.3 which is installed if you run pip install -e ".[dev]" from the cloned repo :)

Could you please revert those changes? It's as simple as running git restore --source origin/main src/diffusers/models/*.py on every directory where you see the unexpectedly deleted lines here: https://github.com/huggingface/diffusers/pull/327/files
(make sure not to run it on pipelines/pndm/*.py though! 😄)

After that we're good to merge! 🤗

@daspartho
Copy link
Contributor Author

Hi @anton-l
I reverted the unexpected changes, could you check it?
Thanks : )

anton-l
anton-l approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member
@anton-l anton-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @daspartho!

@anton-l anton-l merged commit 7b628a2 into huggingface:main Sep 2, 2022
@anton-l anton-l mentioned this pull request Sep 2, 2022
Closed
natolambert pushed a commit that referenced this pull request Sep 7, 2022
@daspartho @natolambert
[Type hint] PNDM pipeline (#327)
a756e02 
* [Type hint] PNDM pipeline

* ran make style

* Revert "ran make style" wrong black version
@danielpatrickhug
Copy link
Contributor

Hi, added a pull request for 27 - 29 #412

PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
@qedawkins
Clean up the v-diffusion install pipeline (huggingface#327)
9bd951b
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
@daspartho
[Type hint] PNDM pipeline (huggingface#327)
590273c 
* [Type hint] PNDM pipeline

* ran make style

* Revert "ran make style" wrong black version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-l anton-l anton-l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daspartho @HuggingFaceDocBuilderDev @anton-l @danielpatrickhug
0