clean: Refactor function to toggle file contents

mrfyda · mrfyda · commit 8ee76bf44bd8 · 2021-01-23T22:16:25.000Z
diff --git a/src/ui/js/diff2html-ui-base.ts b/src/ui/js/diff2html-ui-base.ts
@@ -113,24 +113,23 @@ export class Diff2HtmlUI {
 
   fileContentToggle(): void {
     this.targetElement.querySelectorAll('.d2h-file-collapse').forEach(fileContentToggleBtn => {
-      const toggle: (e: Event) => void = e => {
-        if (fileContentToggleBtn === e.target) return;
-
-        const fileContentLineByLine: HTMLElement | null | undefined = fileContentToggleBtn
-          .closest('.d2h-file-wrapper')
-          ?.querySelector('.d2h-file-diff');
-        const fileContentSideBySide: HTMLElement | null | undefined = fileContentToggleBtn
+      const toggleFileContents: (selector: string) => void = selector => {
+        const fileContents: HTMLElement | null | undefined = fileContentToggleBtn
           .closest('.d2h-file-wrapper')
-          ?.querySelector('.d2h-files-diff');
+          ?.querySelector(selector);
 
-        if (fileContentLineByLine !== null && fileContentLineByLine !== undefined)
-          fileContentLineByLine.style.display = fileContentLineByLine.style.display === 'none' ? '' : 'none';
+        if (fileContents !== null && fileContents !== undefined)
+          fileContents.style.display = fileContents.style.display === 'none' ? '' : 'none';
+      };
+
+      const toggleHandler: (e: Event) => void = e => {
+        if (fileContentToggleBtn === e.target) return;
 
-        if (fileContentSideBySide !== null && fileContentSideBySide !== undefined)
-          fileContentSideBySide.style.display = fileContentSideBySide.style.display === 'none' ? '' : 'none';
+        toggleFileContents('.d2h-file-diff');
+        toggleFileContents('.d2h-files-diff');
       };
 
-      fileContentToggleBtn.addEventListener('click', e => toggle(e));
+      fileContentToggleBtn.addEventListener('click', e => toggleHandler(e));
     });
   }
 
